The best linux kernel commit message ever
As you can see at this patch, Stephen Hemminger has submitted what I would call the best Linux Kernel commit message ever:
In days of old in 2.6.29, netfilter did locketh using a lock of the reader kind when doing its table business, and do a writer when with pen in hand like a overworked accountant did replace the tables. This sucketh and caused the single lock to fly back and forth like a poor errant boy. But then netfilter was blessed with RCU and the performance was divine, but alas there were those that suffered for trying to replace their many rules one at a time. So now RCU must be vanquished from the scene, and better chastity belts be placed upon this valuable asset most dear. The locks that were but one are now replaced by one per suitor. The repair was made after much discussion involving Eric the wise, and Linus the foul. With flowers springing up amid the thorns some peace has finally prevailed and all is soothed. This patch and purple prose was penned by in honor of "Talk like Shakespeare" day. Signed-off-by: Stephen Hemminger--- What hath changed over the last two setting suns: * more words, mostly correct... * no need to locketh for writeh on current cpu tis always so * the locking of all cpu's on replace is always done as part of the get_counters cycle, so the sychronize swip in replace tables is gone with only a comment remaing include/linux/netfilter/x_tables.h | 55 ++++++++++++++-- net/ipv4/netfilter/arp_tables.c | 125 ++++++++++-------------------------- net/ipv4/netfilter/ip_tables.c | 126 ++++++++++--------------------------- net/ipv6/netfilter/ip6_tables.c | 123 ++++++++++-------------------------- net/netfilter/x_tables.c | 55 ++++++++-------- 5 files changed, 188 insertions(+), 296 deletions(-)
Thanks Stephen, you made my day :)